Support pymongo 4 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dill0wn
force-pushed
the
dw/pymongo4-prep
branch
from
d9b4cbe
to
6d0ee6e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 90.19% 91.10% +0.90%
==========================================
Files 43 43
Lines 6724 6702 -22
==========================================
+ Hits 6065 6106 +41
+ Misses 659 596 -63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brondsem
requested changes
Jul 1, 2024
brondsem
reviewed
Jul 1, 2024
brondsem
reviewed
Jul 5, 2024
dill0wn
force-pushed
the
dw/pymongo4-prep
branch
3 times, most recently
from
801c5be
to
d2bf051
Compare
brondsem
approved these changes
Jul 10, 2024
|
All the code changes look good. Lets continue to test with more codebases and maybe pymongo 4 itself, before merging. |
brondsem
reviewed
Jul 11, 2024
ming/metadata.pyi
Outdated
| @@ -193,16 +193,16 @@ class _ClassManager(Generic[M]): | |||
| def remove(self, spec_or_id: Union[MongoFilter, ObjectId] = None, **kwargs) -> ChangeResult: ... | |||
| def count(self) -> int: ... | |||
| def update_partial(self, filter: MongoFilter, fields: dict, **kwargs) -> ChangeResult: ... | |||
There was a problem hiding this comment.
ChangeResult is an alias for dict (above). This should be updated to pymongo UpdateResult and DeleteResult
dill0wn
force-pushed
the
dw/pymongo4-prep
branch
from
dc7e74a
to
e65fec5
Compare
dill0wn
force-pushed
the
dw/pymongo4-prep
branch
from
ccf05df
to
eed990b
Compare
dill0wn
force-pushed
the
dw/pymongo4-prep
branch
from
3772233
to
7e42e85
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was motivated by this issue #48 requesting pymongo v4 support. This PR lays the groundwork for the upgrade to pymongo4, but it stops short of actually bumping the package.
I followed pymongo's migration guide to see what was removed or deprecated then updated everything relevant in Ming. pymongo has backported many of their API changes to pymongo3 therefore I think this work should be representative.
That said, I'm sure more issues will crop up once we actually update to pymongo4, but that can be a separate chunk of work.